txm: rebind read trackers of rollbacked txns#6335
Merged
Korablev77 merged 1 commit intomasterfrom Aug 18, 2021
Merged
Conversation
619c486 to
f77d286
Compare
alyapunov
approved these changes
Aug 17, 2021
Contributor
alyapunov
left a comment
There was a problem hiding this comment.
Good, but it seems that it is half done job - what if the newer story is NULL? I guess we should rebind to older story. What if older story is NULL too? we should create hole record.
RW transactions used to commit without problems after rollback of transactions holding stories responsible to track their reads. That behaviour led to unserializable results. This patch fixes this problem. Closes #6325
f77d286 to
c9b187c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RW transactions used to commit without problems after rollback of transactions holding stories responsible to track their reads.
That behaviour led to unserializable results. This patch fixes this problem.
Closes #6325