vinyl: unthrottle scheduler for checkpoint#12346
Merged
locker merged 1 commit intotarantool:masterfrom Feb 26, 2026
Merged
Conversation
The scheduler is throttled after a dump/compaction error to avoid spamming logs in case of a repetitive disk error, like running out of disk space. However, if the user calls `box.snapshot()` it must be unthrottled. Although we do clear the `is_throttled` flag, we don't wake up the scheduler fiber so this doesn't work as expected. Fix it. BTW this should speed up those Vinyl tests that use error injections for failing dump/compaction tasks. Closes tarantool#12342 NO_DOC=bug fix
nshy
approved these changes
Feb 25, 2026
xuniq
approved these changes
Feb 26, 2026
Member
Author
|
Cherry-picked to 3.2, 3.3, 3.5, 3.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduler is throttled after a dump/compaction error to avoid spamming logs in case of a repetitive disk error, like running out of disk space. However, if the user calls
box.snapshot()it must be unthrottled. Although we do clear theis_throttledflag, we don't wake up the scheduler fiber so this doesn't work as expected. Fix it.BTW this should speed up those Vinyl tests that use error injections for failing dump/compaction tasks.
Closes #12342