Skip to content

box: fix crash with transactional trigger on system space#12138

Merged
locker merged 1 commit intotarantool:masterfrom
nshy:gh-11766-txn-trigger-on-system-space
Dec 15, 2025
Merged

box: fix crash with transactional trigger on system space#12138
locker merged 1 commit intotarantool:masterfrom
nshy:gh-11766-txn-trigger-on-system-space

Conversation

@nshy
Copy link
Contributor

@nshy nshy commented Dec 10, 2025

Currently transactional trigger on space _space causes crash on DDL which changes record for _space itself in _space. In particular this happens on recovery. Similarly there is a crash on trigger on space _index and changing record for _index itself in _index.

The issue is we first commit the DDL which destroys the old space and then run transactional trigger which refers to the old space. Let's do the opposite, first run transactional trigger.

Closes #11766

@nshy nshy requested a review from a team as a code owner December 10, 2025 11:32
@coveralls
Copy link

coveralls commented Dec 10, 2025

Coverage Status

coverage: 87.64% (-0.008%) from 87.648%
when pulling fd84205 on nshy:gh-11766-txn-trigger-on-system-space
into 53c3101
on tarantool:master
.

@nshy nshy requested a review from locker December 10, 2025 11:54
@locker locker assigned nshy and unassigned locker Dec 10, 2025
Currently transactional trigger on space `_space` causes crash on DDL
which changes record for `_space` itself in `_space`. In particular this
happens on recovery. Similarly there is a crash on trigger on space
`_index` and changing record for `_index` itself in `_index`.

The issue is we first commit the DDL which destroys the old space and
then run transactional trigger which refers to the old space. Let's do
the opposite, first run transactional trigger.

Closes tarantool#11766

NO_DOC=bugfix
@nshy nshy force-pushed the gh-11766-txn-trigger-on-system-space branch from 07bc6e3 to fd84205 Compare December 15, 2025 08:30
@nshy nshy added the full-ci Enables all tests for a pull request label Dec 15, 2025
@nshy nshy assigned locker and unassigned nshy Dec 15, 2025
@locker locker merged commit 37c43af into tarantool:master Dec 15, 2025
59 of 61 checks passed
@locker
Copy link
Member

locker commented Dec 15, 2025

Cherry-picked to 3.6, 3.5, 3.3, 3.2.

@nshy nshy deleted the gh-11766-txn-trigger-on-system-space branch December 17, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Enables all tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash on recovery with system space transactional trigger

4 participants