box: compare pagination position against key only for tree index#11964
Merged
sergepetrenko merged 1 commit intotarantool:masterfrom Oct 27, 2025
Merged
box: compare pagination position against key only for tree index#11964sergepetrenko merged 1 commit intotarantool:masterfrom
sergepetrenko merged 1 commit intotarantool:masterfrom
Conversation
lenkis
approved these changes
Oct 22, 2025
changelogs/unreleased/gh-11963-crash-pagination-with-key-rtree.md
Outdated
Show resolved
Hide resolved
nshy
approved these changes
Oct 23, 2025
locker
approved these changes
Oct 23, 2025
Currently, we check that pagination position meets search criteria, otherwise the invalid position can break Tarantool or lead to invalid results. However, this check mustn't be done for `rtree` index because it works with `array` fields and our comparators don't support them. Since this check makes sense only for `tree` index (because it's the only ordered index), let's simply omit this check for other indexes. Closes tarantool#11963 NO_DOC=bugfix
e7f3dcf to
9e87b46
Compare
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
Backport summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we check that pagination position meets search criteria, otherwise the invalid position can break Tarantool or lead to invalid results. However, this check mustn't be done for
rtreeindex because it works witharrayfields and our comparators don't support them. Since this check makes sense only fortreeindex (because it's the only ordered index), let's simply omit this check for other indexes.Closes #11963