Skip to content

box: populate sysview iterator with position method#11954

Merged
sergepetrenko merged 1 commit intotarantool:masterfrom
drewdzzz:pagination_sysview
Oct 21, 2025
Merged

box: populate sysview iterator with position method#11954
sergepetrenko merged 1 commit intotarantool:masterfrom
drewdzzz:pagination_sysview

Conversation

@drewdzzz
Copy link
Contributor

@drewdzzz drewdzzz commented Oct 20, 2025

Currently Tarantool crashes when one tries to use pagination on a sysview space because it doesn't have iterator_position method and it's even not initialized to a generic version throwing an error. Anyway, sysview spaces support only tree indexes, so pagination definitely may work there - let's populate this engine with iterator_position method which simply call the same method of the underlying iterator.

Closes #11953

NO_DOC=bugfix

@drewdzzz drewdzzz requested a review from a team as a code owner October 20, 2025 12:28
@coveralls
Copy link

coveralls commented Oct 20, 2025

Coverage Status

coverage: 87.628% (+0.008%) from 87.62%
when pulling a60a4df on drewdzzz:pagination_sysview
into 9b3bec0
on tarantool:master
.

@mkostoevr mkostoevr removed their assignment Oct 20, 2025
@nshy nshy assigned drewdzzz and unassigned nshy Oct 20, 2025
@drewdzzz drewdzzz added full-ci Enables all tests for a pull request backport/3.2 Automatically create a 3.2 backport PR backport/3.3 Automatically create a 3.3 backport PR backport/3.4 Automatically create a 3.4 backport PR backport/3.5 Automatically create a 3.5 backport PR and removed full-ci Enables all tests for a pull request backport/3.2 Automatically create a 3.2 backport PR backport/3.3 Automatically create a 3.3 backport PR backport/3.4 Automatically create a 3.4 backport PR backport/3.5 Automatically create a 3.5 backport PR labels Oct 21, 2025
Currently Tarantool crashes when one tries to use pagination on a
`sysview` space because it doesn't have `iterator_position` method
and it's even not initialized to a generic version throwing an error.
Anyway, `sysview` spaces support only `tree` indexes, so pagination
definitely may work there - let's populate this engine with
`iterator_position` method which simply calls the same method of
the underlying iterator.

Closes tarantool#11953

NO_DOC=bugfix
@drewdzzz drewdzzz removed their assignment Oct 21, 2025
@sergepetrenko sergepetrenko added backport/3.2 Automatically create a 3.2 backport PR backport/3.3 Automatically create a 3.3 backport PR backport/3.4 Automatically create a 3.4 backport PR backport/3.5 Automatically create a 3.5 backport PR and removed full-ci Enables all tests for a pull request labels Oct 21, 2025
@sergepetrenko sergepetrenko merged commit ffa157d into tarantool:master Oct 21, 2025
92 checks passed
@TarantoolBot
Copy link
Collaborator

Successfully created backport PR for release/3.2:

@TarantoolBot
Copy link
Collaborator

Successfully created backport PR for release/3.3:

@TarantoolBot
Copy link
Collaborator

Successfully created backport PR for release/3.4:

@TarantoolBot
Copy link
Collaborator

Successfully created backport PR for release/3.5:

@TarantoolBot
Copy link
Collaborator

Backport summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/3.2 Automatically create a 3.2 backport PR backport/3.3 Automatically create a 3.3 backport PR backport/3.4 Automatically create a 3.4 backport PR backport/3.5 Automatically create a 3.5 backport PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Virtual space select with pagination segfaults

7 participants