replication: update raft instance id on anon replica register#11940
Merged
sergepetrenko merged 1 commit intotarantool:masterfrom Oct 16, 2025
Merged
Conversation
a392fd6 to
9d1d692
Compare
Gerold103
reviewed
Oct 15, 2025
Collaborator
Gerold103
left a comment
There was a problem hiding this comment.
Oh, what a miss! Lucky it was found. But also means that the anon replicas don't seem to be used much by the users together with the synchronous replication.
changelogs/unreleased/gh-11938-stale-raft-state-after-register.md
Outdated
Show resolved
Hide resolved
7f9f18d to
a554635
Compare
Gerold103
approved these changes
Oct 16, 2025
lenkis
approved these changes
Oct 16, 2025
changelogs/unreleased/gh-11938-stale-election-state-after-register.md
Outdated
Show resolved
Hide resolved
The raft subsystem has its own copy of an instance id, raft::self. It's set during initial `box.cfg()` call, after local recovery or bootstrap. It was forgotten to update raft::self after an anonymous replica register. This could lead to various assertion failures in raft code in debug build, and in the release build the raft state would be silently corrupted. Fix this. Closes tarantool#11938 NO_DOC=bugfix
6fdd647 to
54b617d
Compare
Collaborator
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/2.11
git worktree add -d .worktree/backport/release/2.11/11940 origin/release/2.11
cd .worktree/backport/release/2.11/11940
git switch --create backport/release/2.11/11940
git cherry-pick -x a4d038dcdd2c52f710226e4bcd963d20f05b9e8a |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
Backport summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The raft subsystem has its own copy of an instance id, raft::self. It's set during initial
box.cfg()call, after local recovery or bootstrap.It was forgotten to update raft::self after an anonymous replica register. This could lead to various assertion failures in raft code in debug build, and in the release build the raft state would be silently corrupted. Fix this.
Closes #11938
NO_DOC=bugfix