diag: remove debug logging from functions setting diag#11937
Merged
locker merged 1 commit intotarantool:masterfrom Oct 17, 2025
Merged
diag: remove debug logging from functions setting diag#11937locker merged 1 commit intotarantool:masterfrom
locker merged 1 commit intotarantool:masterfrom
Conversation
locker
reviewed
Oct 15, 2025
17c2066 to
cca18b9
Compare
When we fail to write a log message to syslog to try to reconnect and write it again in `write_to_syslog()`. If reconnecting failed and log level is debug we log error but this involves another reconnecting attempt and so on. As result Tarantool is crashed due to stack overflow. Let's remove logging error in `diag_set()` and `diag_add()`. Is not considered useful. Debug logging produces a lot of messages, to make it helpful we are going support turning logging on by module. In this case logging all errors in diag.h will not be helpful. Closes tarantool#11840 NO_DOC=bugfix
cca18b9 to
9bba744
Compare
locker
approved these changes
Oct 16, 2025
lenkis
approved these changes
Oct 16, 2025
Member
|
Cherry-picked to 3.2, 3.3, 3.4, 3.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we fail to write a log message to syslog to try to reconnect and write it again in
write_to_syslog(). If reconnecting failed and log level is debug we log error but this involves another reconnecting attempt and so on. As result Tarantool is crashed due to stack overflow.Let's remove logging error in
diag_set()anddiag_add(). Is not considered useful. Debug logging produces a lot of messages, to make it helpful we are going support turning logging on by module. In this case logging all errors indiag.hwill not be helpful.Closes #11840
See also https://github.com/tarantool/tarantool-ee/pull/1499 PR required after these changes.