Skip to content

memtx: failing index count limit assertion with MVCC enabled#11930

Merged
sergepetrenko merged 1 commit intotarantool:masterfrom
Astronomax:gh-11929-mvcc-failing-index-count-limit-assertion
Oct 27, 2025
Merged

memtx: failing index count limit assertion with MVCC enabled#11930
sergepetrenko merged 1 commit intotarantool:masterfrom
Astronomax:gh-11929-mvcc-failing-index-count-limit-assertion

Conversation

@Astronomax
Copy link
Contributor

@Astronomax Astronomax commented Oct 15, 2025 •
edited
Loading

Fixed a crash when using the maximum allowed number of indexes with Memtx-MVCC enabled.

Closes #11929

NO_DOC=bugfix

@Astronomax Astronomax requested a review from a team as a code owner October 15, 2025 08:34
lenkis
lenkis approved these changes Oct 16, 2025
View reviewed changes
CuriousGeorgiy
CuriousGeorgiy requested changes Oct 21, 2025
View reviewed changes
@Astronomax Astronomax force-pushed the gh-11929-mvcc-failing-index-count-limit-assertion branch 3 times, most recently from bf7a824 to 9203b83 Compare October 22, 2025 13:49
@Astronomax Astronomax force-pushed the gh-11929-mvcc-failing-index-count-limit-assertion branch from 9203b83 to 13f6edf Compare October 22, 2025 14:01
@coveralls
Copy link

coveralls commented Oct 22, 2025 •
edited
Loading

Coverage Status

coverage: 87.646% (+0.04%) from 87.61%
when pulling 3c4ff35 on Astronomax:gh-11929-mvcc-failing-index-count-limit-assertion
into 2a9a463
on tarantool:master.

CuriousGeorgiy
CuriousGeorgiy approved these changes Oct 22, 2025
View reviewed changes
drewdzzz
drewdzzz requested changes Oct 23, 2025
View reviewed changes
@drewdzzz drewdzzz assigned Astronomax and unassigned drewdzzz Oct 23, 2025
@Astronomax Astronomax force-pushed the gh-11929-mvcc-failing-index-count-limit-assertion branch from 13f6edf to 4404404 Compare October 23, 2025 15:07
@Astronomax Astronomax requested a review from drewdzzz October 23, 2025 15:08
@Astronomax Astronomax assigned drewdzzz and unassigned Astronomax Oct 23, 2025
drewdzzz
drewdzzz approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@drewdzzz drewdzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's merge it after #11662 (do not forget to rebase).

@drewdzzz drewdzzz added the do not merge Not ready to be merged label Oct 24, 2025
@drewdzzz drewdzzz assigned Astronomax and unassigned drewdzzz Oct 24, 2025
@Astronomax Astronomax force-pushed the gh-11929-mvcc-failing-index-count-limit-assertion branch from 4404404 to 0309776 Compare October 24, 2025 08:28
@Astronomax Astronomax changed the title mvcc: failing index count limit assertion memtx: failing index count limit assertion with MVCC enabled Oct 24, 2025
@Astronomax Astronomax force-pushed the gh-11929-mvcc-failing-index-count-limit-assertion branch from 0309776 to 8e1d769 Compare October 24, 2025 10:43
@Astronomax Astronomax added the full-ci Enables all tests for a pull request label Oct 24, 2025
@sergepetrenko sergepetrenko added backport/3.2 Automatically create a 3.2 backport PR backport/3.3 Automatically create a 3.3 backport PR backport/3.4 Automatically create a 3.4 backport PR backport/3.5 Automatically create a 3.5 backport PR and removed full-ci Enables all tests for a pull request labels Oct 27, 2025
@Astronomax @sergepetrenko
memtx: failing index count limit assertion with MVCC enabled
3c4ff35 
Fixed a crash when using the maximum allowed number of indexes with
Memtx-MVCC enabled.

Closes tarantool#11929

NO_DOC=bugfix
@sergepetrenko sergepetrenko force-pushed the gh-11929-mvcc-failing-index-count-limit-assertion branch from 8e1d769 to 3c4ff35 Compare October 27, 2025 09:55
@sergepetrenko sergepetrenko removed the do not merge Not ready to be merged label Oct 27, 2025
@sergepetrenko sergepetrenko merged commit d4be554 into tarantool:master Oct 27, 2025
27 checks passed
@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Oct 27, 2025

Backport failed for release/3.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.2
git worktree add -d .worktree/backport/release/3.2/11930 origin/release/3.2
cd .worktree/backport/release/3.2/11930
git switch --create backport/release/3.2/11930
git cherry-pick -x d4be554057cef2bacecb3b115ef8aa218c914631

@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Oct 27, 2025

Backport failed for release/3.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.3
git worktree add -d .worktree/backport/release/3.3/11930 origin/release/3.3
cd .worktree/backport/release/3.3/11930
git switch --create backport/release/3.3/11930
git cherry-pick -x d4be554057cef2bacecb3b115ef8aa218c914631

@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Oct 27, 2025

Successfully created backport PR for release/3.4:

@TarantoolBot TarantoolBot mentioned this pull request Oct 27, 2025
Merged
@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Oct 27, 2025

Successfully created backport PR for release/3.5:

@TarantoolBot TarantoolBot mentioned this pull request Oct 27, 2025
Merged
@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Oct 27, 2025

Backport summary

@sergepetrenko
Copy link
Collaborator

sergepetrenko commented Oct 27, 2025

@Astronomax, please, prepare backports for branches 3.2 and 3.3

This was referenced Oct 28, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenkis lenkis lenkis approved these changes

@CuriousGeorgiy CuriousGeorgiy CuriousGeorgiy approved these changes

@drewdzzz drewdzzz drewdzzz approved these changes

Assignees

@sergepetrenko sergepetrenko

Labels

backport/3.2 Automatically create a 3.2 backport PR backport/3.3 Automatically create a 3.3 backport PR backport/3.4 Automatically create a 3.4 backport PR backport/3.5 Automatically create a 3.5 backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mvcc: failing index count limit assertion

7 participants

@Astronomax @coveralls @TarantoolBot @sergepetrenko @lenkis @CuriousGeorgiy @drewdzzz