box: mark replication role as system#11852
Merged
sergepetrenko merged 1 commit intotarantool:masterfrom Sep 25, 2025
Merged
Conversation
sergepetrenko
approved these changes
Sep 24, 2025
Collaborator
sergepetrenko
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Please assign me on PRs you want me to look at so that I don't miss them in https://github.com/pulls/assigned
The `replication` role (id = 3) was predefined but not included in the system users/roles definitions. As a result, it was not protected from being dropped or modified, unlike `guest`, `admin`, `public`, and `super`. This patch adds `replication` to the list of system roles and extends `BOX_SYSTEM_USER_ID_MAX` accordingly, so that the role is treated consistently as a system entity. Follow-up to tarantool#1205, tarantool#3084. Closes tarantool#11848 NO_DOC=already in doc
877af89 to
af61036
Compare
xuniq
approved these changes
Sep 24, 2025
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
Backport summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
replicationrole (id = 3) was predefined but not included in the system users/roles definitions. As a result, it was not protected from being dropped or modified, unlikeguest,admin,public, andsuper.This patch adds
replicationto the list of system roles and extendsBOX_SYSTEM_USER_ID_MAXaccordingly, so that the role is treated consistently as a system entity.Follow-up to #1205, #3084.
Closes #11848
NO_DOC=already in doc