Skip to content

config: expand vars in any nodes#11841

Merged
Totktonada merged 1 commit intotarantool:masterfrom
mandesero:mandesero/gh-10595-config-context-vars-expansion
Sep 22, 2025
Merged

config: expand vars in any nodes#11841
Totktonada merged 1 commit intotarantool:masterfrom
mandesero:mandesero/gh-10595-config-context-vars-expansion

Conversation

@mandesero
Copy link
Contributor

Template variables (e.g. {{ context.title }}, {{ instance_name }}) are now expanded inside app.cfg.* and roles_cfg.* (any type fields).

Closes #10595

@mandesero mandesero requested review from a team and Totktonada as code owners September 16, 2025 09:54
@coveralls
Copy link

coveralls commented Sep 16, 2025

Coverage Status

coverage: 87.608% (-0.03%) from 87.634%
when pulling e35564d on mandesero:mandesero/gh-10595-config-context-vars-expansion
into 37bca56
on tarantool:master
.

@georgiy-belyanin georgiy-belyanin self-requested a review September 16, 2025 10:27
@georgiy-belyanin georgiy-belyanin self-assigned this Sep 16, 2025
Copy link
Member

@georgiy-belyanin georgiy-belyanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this bug! Probably, it is really better to implement it as a part of the generic schema.

@mandesero mandesero force-pushed the mandesero/gh-10595-config-context-vars-expansion branch from 54cff14 to 4563f9a Compare September 18, 2025 09:50
@mandesero mandesero removed their assignment Sep 18, 2025
@mandesero mandesero force-pushed the mandesero/gh-10595-config-context-vars-expansion branch from 4563f9a to 5b5422d Compare September 19, 2025 12:08
@mandesero mandesero force-pushed the mandesero/gh-10595-config-context-vars-expansion branch 2 times, most recently from aaa3570 to ad7e41a Compare September 19, 2025 13:07
@mandesero mandesero force-pushed the mandesero/gh-10595-config-context-vars-expansion branch from ad7e41a to 9b11429 Compare September 19, 2025 18:51
Template variables (e.g. `{{ context.title }}`,
`{{ instance_name }})` are now expanded inside `app.cfg.*` and
`roles_cfg.*` (`any` type fields). Expansion is applied recursively
to all string values, ensuring consistent behavior across the
entire config tree.

Closes tarantool#10595

NO_DOC=bugfix
@mandesero mandesero force-pushed the mandesero/gh-10595-config-context-vars-expansion branch from 9b11429 to e35564d Compare September 19, 2025 19:31
Copy link
Contributor

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@georgiy-belyanin georgiy-belyanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@Totktonada Totktonada added the full-ci Enables all tests for a pull request label Sep 22, 2025
@Totktonada Totktonada merged commit bae255b into tarantool:master Sep 22, 2025
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Enables all tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

config: context variables do not work in roles_cfg.<...> and app.cfg.<...>

5 participants