config: sync users with config on reload#11828
Merged
sergos merged 1 commit intotarantool:masterfrom Sep 30, 2025
Merged
Conversation
Totktonada
reviewed
Sep 8, 2025
Totktonada
reviewed
Sep 8, 2025
3321ef6 to
f4a8e21
Compare
mandesero
commented
Sep 12, 2025
f4a8e21 to
b3220f5
Compare
Totktonada
reviewed
Sep 16, 2025
Totktonada
reviewed
Sep 16, 2025
Totktonada
reviewed
Sep 16, 2025
b3220f5 to
e8d5edb
Compare
Totktonada
reviewed
Sep 16, 2025
Totktonada
reviewed
Sep 16, 2025
Totktonada
reviewed
Sep 16, 2025
e8d5edb to
5a52d71
Compare
5a52d71 to
51af3c3
Compare
locker
approved these changes
Sep 23, 2025
cde04b5 to
75d662f
Compare
mandesero
commented
Sep 24, 2025
Totktonada
reviewed
Sep 24, 2025
Totktonada
reviewed
Sep 24, 2025
Totktonada
reviewed
Sep 25, 2025
Totktonada
reviewed
Sep 25, 2025
Totktonada
reviewed
Sep 25, 2025
Totktonada
reviewed
Sep 25, 2025
Totktonada
reviewed
Sep 25, 2025
Totktonada
reviewed
Sep 25, 2025
maryiaLichko
approved these changes
Sep 25, 2025
maryiaLichko
left a comment
There was a problem hiding this comment.
chagelog is ok for me. if changed -> request review again
a86d5de to
d662fc4
Compare
Totktonada
reviewed
Sep 25, 2025
d662fc4 to
13a364f
Compare
Totktonada
reviewed
Sep 25, 2025
Totktonada
reviewed
Sep 25, 2025
Totktonada
approved these changes
Sep 25, 2025
Contributor
Totktonada
left a comment
There was a problem hiding this comment.
Thank you for the decent work!
Of course, it would be nice to move to runtime users and privileges. I hope it will be some of our next steps.
13a364f to
fd9f258
Compare
georgiy-belyanin
approved these changes
Sep 29, 2025
Member
georgiy-belyanin
left a comment
There was a problem hiding this comment.
Thank you! This is some really neat work!
fd9f258 to
2039aa9
Compare
Previously, if a user or role was removed from `credentials.users` or `credentials.roles` in config, it still remained in the instance after reload. This was intentional to prevent bricking when an empty `credentials` section was rolled out, but it left stale accounts and roles in the system, which is a security risk. Now both users and roles are synchronized with config on reload: - users/roles missing from config are dropped, - users/roles present in config are created/updated, - manually created users/roles remain untouched. Closes tarantool#11827 NO_DOC=bugfix
2039aa9 to
ed72d08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a user or role was removed from
credentials.usersorcredentials.rolesin config, it still remained in the instance after reload. This was intentional to prevent bricking when an emptycredentialssection was rolled out, but it left stale accounts and roles in the system, which is a security risk.Now both users and roles are synchronized with config on reload:
Closes #11827