box: fix setting box error name#11747
Merged
locker merged 1 commit intotarantool:masterfrom Aug 25, 2025
Merged
Conversation
f69b81c to
2eb721b
Compare
locker
reviewed
Aug 11, 2025
80dc5fb to
44da324
Compare
locker
approved these changes
Aug 12, 2025
maryiaLichko
approved these changes
Aug 13, 2025
44da324 to
9ac03ed
Compare
9ac03ed to
bc4a93d
Compare
Contributor
Author
|
The PR depends on #11716 it terms of backporting. |
bc4a93d to
8b17cfe
Compare
Contributor
Author
|
Rebased on master. |
Currently we fail to set box error name is some cases. Error name is error payload with key `name`. Let's cleanup error code a bit. As result the bug will be fixed. 1. Use `va_list` in error constructors so in order to remove error reinitialization in build functions. 2. Use ClientCode for building ER_UNSUPPORTED_INDEX_FEATURE. It is ClientError too. 3. Drop tnt_error() which has a single usage. 4. Drop logged error. It is just a ClientError that is logged when created. Closes tarantool#10708 NO_DOC=bugfix
8b17cfe to
ad929b9
Compare
Member
|
@nshy Please backport to 3.2, 3.3, and 3.4. |
This was referenced Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we fail to set box error name is some cases. Error name is error payload with key
name.Closes #10708