core: fix interval MsgPack decoding#11730
Merged
locker merged 1 commit intotarantool:masterfrom Aug 6, 2025
Merged
Conversation
locker
reviewed
Aug 4, 2025
f74f62e to
20baafc
Compare
locker
approved these changes
Aug 5, 2025
xuniq
approved these changes
Aug 6, 2025
Currently we do not check if we have enough data to read when loading field key. While at it also fix limits checking for `year`, `month`, `week` and `nanoseconds` fields we lost in the commit 01c7ae1 ("msgpack: fix decoding intervals with int64"). Also as we check the upper limit for `ajust` field let's check the lower limit too. Closes tarantool#10360 NO_DOC=bugfix
20baafc to
1f6d24b
Compare
Member
|
Cherry-picked to 3.2, 3.3, 3.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we do not check if we have enough data to read when loading field key.
While at it also fix limits checking for
year,month,weekandnanosecondsfields we lost in the commit 01c7ae1 ("msgpack: fix decoding intervals with int64").Also as we check the upper limit for
ajustfield let's check the lower limit too.Closes #10360