[backport 3.4] box: fix crash while nil-uuid subscribe request#11633
Merged
sergepetrenko merged 1 commit intorelease/3.4from Jul 8, 2025
Merged
[backport 3.4] box: fix crash while nil-uuid subscribe request#11633sergepetrenko merged 1 commit intorelease/3.4from
sergepetrenko merged 1 commit intorelease/3.4from
Conversation
Before this patch a master node could crash when it processed an anonymous iproto subscribe request which had a nil instance uuid. The reason of this error is that in `box_connect_replica` we didn't throw an error when non-exist replica tried to connect to node. It led to a situation when the nullified replica object was tried to dereferenced while iproto subscribe request. Now, we raise an ER_NIL_UUID error if we get an iproto request with nil `instance_uuid`. After this change `test_fetch_snapshot_no_uuid` and `test_checkpoint_join` start fail. The reason of these failures is an incorrect err.type and err.msg of iproto response when we try to send an iproto request with nil `instance_uuid`. Now, these tests are fixed by changing an err.type and err.msg to appropriate values. Also we change `gh_10155_make_iproto_resistant_to_misusage` test because `write_fetch_snapshot` wasn't be able to send iproto fetch_snapshot request with uuid. It led to situation when ER_NIL_UUID error was raised during fetch_snapshot and as a result we weren't be able to read snapshot after this. It broke `test_iproto_crash_fetch_snapshot_subscribe` and `test_iproto_crash_fetch_snapshot_subscribe_not_anon`. Closes #11531 NO_DOC=bugfix (cherry picked from commit 0ba7505)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR is a backport of #11593 to
release/3.4to a future3.4.1release.)Before this patch a master node could crash when it processed an
anonymous iproto subscribe request which had a nil instance uuid.
The reason of this error is that in
box_connect_replicawe didn'tthrow an error when non-exist replica tried to connect to node. It
led to a situation when the nullified replica object was tried to
dereferenced while iproto subscribe request. Now, we raise an
ER_NIL_UUID error if we get an iproto request with nil
instance_uuid.After this change
test_fetch_snapshot_no_uuidandtest_checkpoint_joinstart fail. The reason of these failures is anincorrect err.type and err.msg of iproto response when we try to send
an iproto request with nil
instance_uuid. Now, these tests are fixedby changing an err.type and err.msg to appropriate values.
Also we change
gh_10155_make_iproto_resistant_to_misusagetest becausewrite_fetch_snapshotwasn't be able to send iproto fetch_snapshotrequest with uuid. It led to situation when ER_NIL_UUID error was raised
during fetch_snapshot and as a result we weren't be able to read
snapshot after this. It broke
test_iproto_crash_fetch_snapshot_subscribeandtest_iproto_crash_fetch_snapshot_subscribe_not_anon.Closes #11531