Skip to content

popen: add is_closed() method#11562

Merged
locker merged 1 commit intotarantool:masterfrom
ImeevMA:imeevma/gh-11492-popen-is-closed-method
Jun 5, 2025
Merged

popen: add is_closed() method#11562
locker merged 1 commit intotarantool:masterfrom
ImeevMA:imeevma/gh-11492-popen-is-closed-method

Conversation

@ImeevMA
Copy link
Collaborator

@ImeevMA ImeevMA commented Jun 3, 2025

This commit adds a method to make it easier to check that popen handle is closed.

Closes #11492

@TarantoolBot document
Title: popen_handle:is_closed() method

The new is_closed() method returns true if the popen handle is closed, and false otherwise.

Usage example:

local ph = popen.new(<...>)
assert(ph:is_closed() == false)
...
ph:close()
assert(ph:is_closed() == true)

@ImeevMA ImeevMA requested a review from a team as a code owner June 3, 2025 14:14
@ImeevMA ImeevMA force-pushed the imeevma/gh-11492-popen-is-closed-method branch from 7d8f52d to 601a004 Compare June 3, 2025 14:47
@ImeevMA ImeevMA requested review from Totktonada and locker June 3, 2025 15:28
@locker locker removed their assignment Jun 3, 2025
@Totktonada Totktonada assigned ImeevMA and unassigned Totktonada Jun 3, 2025
@coveralls
Copy link

coveralls commented Jun 3, 2025

Coverage Status

coverage: 87.486% (-0.03%) from 87.513%
when pulling c6e3d67 on ImeevMA:imeevma/gh-11492-popen-is-closed-method
into 3ce3f3e
on tarantool:master
.

@ImeevMA ImeevMA force-pushed the imeevma/gh-11492-popen-is-closed-method branch from 601a004 to b98d43b Compare June 4, 2025 06:23
This commit adds a method to make it easier to check that popen handle
is closed.

Closes tarantool#11492

@TarantoolBot document
Title: `popen_handle:is_closed()` method

The new `is_closed()` method returns `true` if the popen handle is
closed, and `false` otherwise.

Usage example:

```lua
local ph = popen.new(<...>)
assert(ph:is_closed() == false)
...
ph:close()
assert(ph:is_closed() == true)
```
@ImeevMA ImeevMA force-pushed the imeevma/gh-11492-popen-is-closed-method branch from b98d43b to c6e3d67 Compare June 4, 2025 10:36
@ImeevMA ImeevMA added the full-ci Enables all tests for a pull request label Jun 4, 2025
@ImeevMA ImeevMA assigned locker and unassigned ImeevMA Jun 5, 2025
@locker locker merged commit 5921a93 into tarantool:master Jun 5, 2025
91 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Enables all tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No straightforward way to check if popen handle is closed

5 participants