config: add fail_if tag for roles and scripts#11510
Merged
Totktonada merged 1 commit intotarantool:masterfrom Jun 16, 2025
Merged
config: add fail_if tag for roles and scripts#11510Totktonada merged 1 commit intotarantool:masterfrom
fail_if tag for roles and scripts#11510Totktonada merged 1 commit intotarantool:masterfrom
Conversation
Totktonada
reviewed
May 20, 2025
Totktonada
reviewed
May 20, 2025
Totktonada
reviewed
May 20, 2025
Totktonada
approved these changes
May 20, 2025
Contributor
Totktonada
left a comment
There was a problem hiding this comment.
Thank you! The code is OK for me.
I see that there are some repeting block of code. If you see how to reduce repetitions without ruining the readability, nice, I'm for that too. If not, OK, let's proceed as is. I don't want to spin around this on review.
maryiaLichko
approved these changes
May 20, 2025
georgiy-belyanin
approved these changes
May 26, 2025
Closes tarantool#10987 Closes TNTP-1016 @TarantoolBot document Title: `fail_if` tag for roles and scripts. If the tag `fail_if` is set to an expression string role/script loading will raise an error, if fail_if expression is evaluated to be `true`. The syntax for `fail_if` tag is the same as in config `conditional.if` section. Example: ```lua -- --- #tarantool.metadata.v1 -- fail_if: "tarantool_version < 3.1.0" -- ... ```
8e249e9 to
f746208
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10987
Closes TNTP-1016
@TarantoolBot document
Title:
fail_iftag for roles and scripts.If the tag
fail_ifis set to an expression string role/script loading will raise an error, if fail_if expression is evaluated to betrue.The syntax for
fail_iftag is the same as in configconditional.ifsection.Example: