box: flush WAL queue on sync#11315
Merged
sergepetrenko merged 1 commit intotarantool:masterfrom Apr 3, 2025
Merged
Conversation
`wal_sync()` is expected to flush all prepared txns on disk. Currently it is not so because we do not flush txns waiting in WAL queue. AFAIU the issue exists for all the places where we use `wal_sync()` (except for `box_wait_limbo_acked()` where we already flush WAL queue). The test is only added for the vinyl index build as there are explicit tickets for that. Closes tarantool#11118 Closes tarantool#11119 NO_DOC=bugfix
sergepetrenko
approved these changes
Apr 1, 2025
Collaborator
sergepetrenko
left a comment
There was a problem hiding this comment.
Thanks for the fix! LGTM.
maryiaLichko
approved these changes
Apr 2, 2025
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
Backport summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wal_sync()is expected to flush all prepared txns on disk. Currently it is not so because we do not flush txns waiting in WAL queue. AFAIU the issue exists for all the places where we usewal_sync()(except forbox_wait_limbo_acked()where we already flush WAL queue). The test is only added for the vinyl index build as there are explicit tickets for that.Closes #11118
Closes #11119