box: fix box.commit({wait = 'none'}) could yield#11314
Merged
sergepetrenko merged 1 commit intotarantool:masterfrom Apr 10, 2025
Merged
box: fix box.commit({wait = 'none'}) could yield#11314sergepetrenko merged 1 commit intotarantool:masterfrom
sergepetrenko merged 1 commit intotarantool:masterfrom
Conversation
sergepetrenko
approved these changes
Apr 1, 2025
Collaborator
sergepetrenko
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing this!
LGTM.
Collaborator
|
Let's also ask @Gerold103 to take a look. |
maryiaLichko
approved these changes
Apr 2, 2025
Gerold103
reviewed
Apr 2, 2025
Collaborator
Gerold103
left a comment
There was a problem hiding this comment.
Thanks for the patch! Huh, it was really an unexpected bug in such a simple place!
0c4f690 to
cf3e457
Compare
The issue is in order to decide whether submitting request to journal would yield or not we check the journal queue size. But the size can be less then limit while queue is not empty. At this moment submitting new request will yield. Closes tarantool#11224 NO_DOC=bugfix
cf3e457 to
786004b
Compare
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
Backport summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is in order to decide whether submitting request to journal would yield or not we check the journal queue size. But the size can be less then limit while queue is not empty. At this moment submitting new request will yield.
Closes #11224