box: rollback txns in WAL queue before in-flight tnxs#11279
Merged
sergepetrenko merged 1 commit intotarantool:masterfrom Mar 27, 2025
Merged
box: rollback txns in WAL queue before in-flight tnxs#11279sergepetrenko merged 1 commit intotarantool:masterfrom
sergepetrenko merged 1 commit intotarantool:masterfrom
Conversation
locker
approved these changes
Mar 21, 2025
61e4f30 to
6cc0689
Compare
xuniq
approved these changes
Mar 21, 2025
Collaborator
sergepetrenko
left a comment
There was a problem hiding this comment.
Thanks! It was a nasty bug.
In case of WAL error we should rollback txns in WAL queue before any
in-flight txns (already submitted to WAL thread).
Work around is to disable WAL queue by `box.cfg{wal_queue_max_size = 0}`
so that no request can be queued.
Closes tarantool#11179
NO_DOC=bugfix
6cc0689 to
b7924f4
Compare
sergepetrenko
approved these changes
Mar 27, 2025
Collaborator
sergepetrenko
left a comment
There was a problem hiding this comment.
Thanks for the fix!
LGTM.
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
Backport summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of WAL error we should rollback txns in WAL queue before any in-flight txns (already submitted to WAL thread).
Work around is to disable WAL queue by
box.cfg{wal_queue_max_size = 0}so that no request can be queued.Closes #11179