test: improve vinyl-luatest/select_consistency_test.lua#11149
Merged
locker merged 2 commits intotarantool:masterfrom Feb 18, 2025
Merged
test: improve vinyl-luatest/select_consistency_test.lua#11149locker merged 2 commits intotarantool:masterfrom
vinyl-luatest/select_consistency_test.lua#11149locker merged 2 commits intotarantool:masterfrom
Conversation
4ff9e01 to
3ad3009
Compare
nshy
approved these changes
Feb 18, 2025
3ad3009 to
345c6ad
Compare
- Do not restart the server and rerun the stress test, because it didn't help us find any new bugs, but it did double the total test execution time. - Reduce the test run time to ~10 seconds and remove it from the long test list. - Pick the transaction isolation level randomly. - Make the padding size random. - Generate 'update' operations in addition to 'insert', 'delete', and 'upsert'. - Inject random fiber yields between operations. - Reduce the number of keys to 1000 and the number of values to 10, because it increases the number of conflicts thus making the test more intensive. Adjust the max padding size, L0 size, cache size, and target range size accordingly. - Enable verbose logging as it may be useful for debugging. - Log all actions taken by the test, because due to the asynchronous nature of the test, it's impossible to debug without logging. - Join test fibers instead of using channels. Closes tarantool#11046 NO_DOC=testing NO_CHANGELOG=testing
The new test vinyl-luatest/select_consistency_test.lua covers all checks performed by the old diff test and at the same time it's much more thorough. Let's drop the old test - it didn't help us find any bugs anyway. NO_DOC=testing NO_CHANGELOG=testing
345c6ad to
e274926
Compare
Member
Author
diffdiff --git a/test/vinyl-luatest/select_consistency_test.lua b/test/vinyl-luatest/select_consistency_test.lua
index b7af179fc200..6a54adbb6875 100644
--- a/test/vinyl-luatest/select_consistency_test.lua
+++ b/test/vinyl-luatest/select_consistency_test.lua
@@ -9,12 +9,13 @@ g.before_all(function(cg)
cg.server = server:new({
alias = 'master',
box_cfg = {
+ log_level = 'verbose',
vinyl_memory = 1024 * 1024,
vinyl_cache = 512 * 1024,
vinyl_run_count_per_level = 1,
vinyl_run_size_ratio = 4,
vinyl_page_size = 1024,
- vinyl_range_size = 128 * 1024,
+ vinyl_range_size = 64 * 1024,
vinyl_bloom_fpr = 0.1,
vinyl_read_threads = 2,
vinyl_write_threads = 4, |
Member
Author
|
Cherry-picked to 2.11, 3.2, 3.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
vinyl-luatest/select_consistency_test.luafaster and more thorough at the same time. It also drops the legacy diff testvinyl/select_consistency.test.lua, because the new test covers all checks performed by the old test and more.Closes #11046
DO NOT MERGE before #11148, because the updated test fails frequently because of the bugs fixed by that PR.