txn: do not rollback transaction statements on timeout#11104
Merged
locker merged 1 commit intotarantool:masterfrom Feb 10, 2025
Merged
txn: do not rollback transaction statements on timeout#11104locker merged 1 commit intotarantool:masterfrom
locker merged 1 commit intotarantool:masterfrom
Conversation
The transaction timeout may be triggered by vinyl taking too long to read disk while executing a statement. If we roll back the transaction in this case, the statement will be deleted, resulting in a crash when we finally try to commit the statement. Actually, in contrast to the case when a transaction is aborted by a fiber yield, there's no need to rollback the transaction on timeout We don't rollback the transaction on conflict so let's not do it on timeout, either. Closes tarantool#11088 NO_DOC=bug fix
drewdzzz
reviewed
Feb 6, 2025
drewdzzz
approved these changes
Feb 7, 2025
lenkis
approved these changes
Feb 7, 2025
Member
Author
|
Cherry-picked to 3.2 and 3.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transaction timeout may be triggered by vinyl taking too long to read disk while executing a statement. If we roll back the transaction in this case, the statement will be deleted, resulting in a crash when we finally try to commit the statement. Actually, in contrast to the case when a transaction is aborted by a fiber yield, there's no need to rollback the transaction on timeout We don't rollback the transaction on conflict so let's not do it on timeout, either.
Closes #11088