wal: use existing logs sizes after restart#11098
Merged
sergepetrenko merged 1 commit intotarantool:masterfrom Mar 27, 2025
Merged
wal: use existing logs sizes after restart#11098sergepetrenko merged 1 commit intotarantool:masterfrom
sergepetrenko merged 1 commit intotarantool:masterfrom
Conversation
505b9a6 to
18dd512
Compare
nshy
requested changes
Feb 6, 2025
changelogs/unreleased/gh-9811-checkpoint-wal-threshold-after-restart.md
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
lenkis
approved these changes
Feb 7, 2025
dfb63b8 to
c32eb00
Compare
nshy
requested changes
Feb 11, 2025
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
c32eb00 to
805586b
Compare
nshy
requested changes
Feb 18, 2025
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Show resolved
Hide resolved
805586b to
310f8ea
Compare
310f8ea to
a2f7daa
Compare
nshy
requested changes
Feb 19, 2025
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Outdated
Show resolved
Hide resolved
test/box-luatest/gh_9811_checkpoint_wal_threshold_after_restart_test.lua
Show resolved
Hide resolved
421c2ce to
3c43a71
Compare
nshy
approved these changes
Feb 24, 2025
Serpentian
reviewed
Feb 26, 2025
During the `checkpoint_wal_threshold` exceedance checks tarantool used to ignore the sizes of files created prior to the server restart which resulted in cases when the server didn't create any checkpoints and generate a huge amount of logs which were replayed each server restart. Now the `wal_dir` is scanned for proper `writer->checkpoint_wal_size` calculation after the recovery process. Fixes tarantool#9811 NO_DOC=bugfix
3c43a71 to
7638032
Compare
Serpentian
approved these changes
Mar 18, 2025
Contributor
Serpentian
left a comment
There was a problem hiding this comment.
Thank you for addressing the comment) I have no more objections
nshy
approved these changes
Mar 24, 2025
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
|
Successfully created backport PR for |
Collaborator
Backport summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the
checkpoint_wal_thresholdexceedance checks tarantool used to ignore the sizes of files created prior to the server restart which resulted in cases when the server didn't create any checkpoints and generate a huge amount of logs which were replayed each server restart. Now thewal_diris scanned for properwriter->checkpoint_wal_sizecalculation after the recovery process.Fixes #9811
NO_DOC=bugfix