Skip to content

box: fix WAL queue size accounting on errors#11082

Merged
locker merged 1 commit intotarantool:masterfrom
nshy:fix-journal-queue-size-accounting
Feb 5, 2025
Merged

box: fix WAL queue size accounting on errors#11082
locker merged 1 commit intotarantool:masterfrom
nshy:fix-journal-queue-size-accounting

Conversation

@nshy
Copy link
Contributor

@nshy nshy commented Feb 3, 2025

If cascade rollback is in progress any new write to WAL will be accounted in queue size forever. Eventually queue size will become larger then threshold forever and writing to WAL will be blocked.

Closes #11081

@nshy nshy requested a review from a team as a code owner February 3, 2025 15:38
@coveralls
Copy link

coveralls commented Feb 3, 2025

Coverage Status

coverage: 87.366% (+0.01%) from 87.355%
when pulling bee3644 on nshy:fix-journal-queue-size-accounting
into 2df3204
on tarantool:master
.

@nshy nshy force-pushed the fix-journal-queue-size-accounting branch from ece68d6 to 85b0cdf Compare February 4, 2025 07:40
@nshy nshy requested a review from locker February 4, 2025 08:00
@locker locker assigned nshy and unassigned locker Feb 4, 2025
If cascade rollback is in progress any new write to WAL will be
accounted in queue size forever. Eventually queue size will become
larger then threshold forever and writing to WAL will be blocked.

Closes tarantool#11081

NO_DOC=bugfix
@nshy nshy force-pushed the fix-journal-queue-size-accounting branch from 85b0cdf to bee3644 Compare February 4, 2025 10:38
@nshy nshy assigned locker and unassigned nshy Feb 4, 2025
@nshy nshy added the full-ci Enables all tests for a pull request label Feb 4, 2025
@nshy nshy assigned locker and unassigned locker Feb 5, 2025
@locker locker merged commit ddc7232 into tarantool:master Feb 5, 2025
95 checks passed
@locker
Copy link
Member

locker commented Feb 5, 2025

Cherry-picked to 2.11, 3.2, 3.3.

@nshy nshy deleted the fix-journal-queue-size-accounting branch February 5, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Enables all tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A sufficient number of cascade rollbacks block the WAL

4 participants