vinyl: fix memory leak on error decoding row during compaction#11051
Merged
locker merged 1 commit intotarantool:masterfrom Jan 27, 2025
Merged
vinyl: fix memory leak on error decoding row during compaction#11051locker merged 1 commit intotarantool:masterfrom
locker merged 1 commit intotarantool:masterfrom
Conversation
Just add missing `vy_page_delete()` to `vy_slice_stream_search()`. The error is very unlikely to happen because: - `vy_slice_stream_search()` is called only once during a compaction task execution. - Memory leaks if `vy_page_find_key()` fails to decode a statement. Practically, this can only occur on memory allocation error. In tests it's triggered by an error injection. Closes tarantool#11044 NO_DOC=bug fix NO_TEST=caught by existing test now and then NO_CHANGELOG=minor; shouldn't normally happen
Collaborator
|
This wouldn't have happened with C++ and RAII 😉😂. |
nshy
approved these changes
Jan 27, 2025
Member
Author
|
Cherry-picked to 2.11, 3.2, 3.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just add missing
vy_page_delete()tovy_slice_stream_search().The error is very unlikely to happen because:
vy_slice_stream_search()is called only once during a compaction task execution.vy_page_find_key()fails to decode a statement. Practically, this can only occur on memory allocation error. In tests it's triggered by an error injection.Closes #11044