Skip to content

test: enable back tests for LuaJIT#10824

Merged
Buristan merged 2 commits intotarantool:masterfrom
Buristan:skaplun/gh-noticket-enable-back-luajit-tests
Dec 17, 2024
Merged

test: enable back tests for LuaJIT#10824
Buristan merged 2 commits intotarantool:masterfrom
Buristan:skaplun/gh-noticket-enable-back-luajit-tests

Conversation

@Buristan
Copy link
Collaborator

Since the commit db351d3 ("luajit: bump new version"), which introduces CTest as a launcher for LuaJIT's test suites, the LuaJIT tests are not run by Tarantool since LUAJIT_USE_TEST is disabled. This patch enables all tests, except ASAN build, due to #10733.

NO_DOC=testing
NO_CHANGELOG=testing
NO_TEST=enable tests back

@Buristan Buristan added qa Issues related to tests or testing subsystem full-ci Enables all tests for a pull request test labels Nov 18, 2024
@Buristan Buristan self-assigned this Nov 18, 2024
@Buristan Buristan added luajit full-ci Enables all tests for a pull request and removed full-ci Enables all tests for a pull request labels Nov 18, 2024
@coveralls
Copy link

coveralls commented Nov 18, 2024

Coverage Status

coverage: 87.377% (+0.02%) from 87.36%
when pulling 55f68a9 on Buristan:skaplun/gh-noticket-enable-back-luajit-tests
into 2afead5
on tarantool:master
.

@Buristan Buristan mentioned this pull request Nov 18, 2024
15 tasks
@Buristan Buristan added the do not merge Not ready to be merged label Dec 4, 2024
@Buristan Buristan force-pushed the skaplun/gh-noticket-enable-back-luajit-tests branch 2 times, most recently from 37775ab to 9ba5ac0 Compare December 5, 2024 11:15
@Buristan Buristan force-pushed the skaplun/gh-noticket-enable-back-luajit-tests branch 4 times, most recently from efff08e to 9ebb380 Compare December 13, 2024 14:13
@Buristan Buristan force-pushed the skaplun/gh-noticket-enable-back-luajit-tests branch from 9ebb380 to 49de4f3 Compare December 16, 2024 12:44
@Buristan Buristan removed the do not merge Not ready to be merged label Dec 16, 2024
@Buristan Buristan assigned Totktonada and ligurio and unassigned Buristan Dec 16, 2024
Copy link
Member

@ligurio ligurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

@ligurio ligurio removed their assignment Dec 16, 2024
@Buristan Buristan marked this pull request as ready for review December 16, 2024 17:50
@Buristan Buristan force-pushed the skaplun/gh-noticket-enable-back-luajit-tests branch from 49de4f3 to e6f7058 Compare December 16, 2024 18:00
This patch is a follow-up for the commit
9542cc2 ("lua: add custom allocator
with memory limit"). LuaJIT tests with enabled GC64 may consume more
than 2 GiB of memory. To avoid failure for these tests, just set the
limit to 128 TiB (LuaJIT maximum for GC64 mode).

Follows up tarantool#8881

NO_DOC=fix LuaJIT tests
NO_CHANGELOG=fix LuaJIT tests
NO_TEST=fix LuaJIT tests
Since the commit db351d3 ("luajit: bump
new version"), which introduces CTest as a launcher for LuaJIT's test
suites, the LuaJIT tests are not run by Tarantool since
`LUAJIT_USE_TEST` is disabled. This patch enables all tests, except ASAN
build, due to tarantool#10733.

NO_DOC=testing
NO_CHANGELOG=testing
NO_TEST=enable tests back
@Buristan Buristan force-pushed the skaplun/gh-noticket-enable-back-luajit-tests branch from e6f7058 to 55f68a9 Compare December 17, 2024 12:03
Copy link
Contributor

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Enables all tests for a pull request luajit qa Issues related to tests or testing subsystem test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants