Skip to content

[backport 2.11] box: fix drop_while integration with index:pairs#10768

Merged
sergepetrenko merged 1 commit intotarantool:release/2.11from
sergepetrenko:luafun-2.11
Oct 31, 2024
Merged

[backport 2.11] box: fix drop_while integration with index:pairs#10768
sergepetrenko merged 1 commit intotarantool:release/2.11from
sergepetrenko:luafun-2.11

Conversation

@sergepetrenko
Copy link
Collaborator

No description provided.

The commit bumps luafun to the new version with a bunch of bugfixes:
* Now `chain` works correctly with iterators without `param`.
* Now `drop_while` supports stateful iterators.
* The module is populated with missing `maximum_by` alias of `max_by`.
* Now `nth` and `length` work correctly with other luafun iterators.

Since our index iterators are stateful (can return different values
with the same `state` passed), the old `drop_while` implementation
didn't work well with them - it was skipping an extra element.
The bump resolves this issue.

Note that there are still methods that don't work correctly with
`index:pairs` - `cycle`, `head` and `is_null`.

Closes tarantool#6403

NO_DOC=bugfix

(cherry picked from commit ec75886)
@coveralls
Copy link

coveralls commented Oct 30, 2024

Coverage Status

coverage: 85.944%. remained the same
when pulling b13aa7e on sergepetrenko:luafun-2.11
into e13c7ed
on tarantool:release/2.11
.

@sergepetrenko sergepetrenko added the full-ci Enables all tests for a pull request label Oct 31, 2024
@sergepetrenko sergepetrenko merged commit 58f3e1d into tarantool:release/2.11 Oct 31, 2024
@sergepetrenko sergepetrenko deleted the luafun-2.11 branch March 17, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Enables all tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants