Skip to content

box: allow to access to the granted role in _vuser space#10747

Merged
sergepetrenko merged 1 commit intotarantool:masterfrom
mkostoevr:m.kostoev/gh-10057-box-schema-user-info
Jul 29, 2025
Merged

box: allow to access to the granted role in _vuser space#10747
sergepetrenko merged 1 commit intotarantool:masterfrom
mkostoevr:m.kostoev/gh-10057-box-schema-user-info

Conversation

@mkostoevr
Copy link
Contributor

@mkostoevr mkostoevr commented Oct 27, 2024

Prior to this patch it was not possible for a user to see any role in the _vuser space except the one created by him and the public one.

Let's also make it possible to see roles that he is granted with, so calls to the box.schema.user.info() functions won't fail if a user has a non-'public' role granted.

Closes #10057

NO_DOC=bugfix

@mkostoevr mkostoevr force-pushed the m.kostoev/gh-10057-box-schema-user-info branch from 4f277ad to c24beb3 Compare October 27, 2024 21:45
@coveralls
Copy link

coveralls commented Oct 27, 2024

Coverage Status

coverage: 87.594% (+0.02%) from 87.579%
when pulling f5cbc0a on mkostoevr:m.kostoev/gh-10057-box-schema-user-info
into b764a77
on tarantool:master
.

@mkostoevr mkostoevr requested a review from drewdzzz October 28, 2024 10:43
@mkostoevr mkostoevr marked this pull request as ready for review October 28, 2024 14:23
@mkostoevr mkostoevr requested a review from a team as a code owner October 28, 2024 14:23
Copy link
Contributor

@drewdzzz drewdzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!
I left a couple of suggestions.

@drewdzzz drewdzzz assigned mkostoevr and unassigned drewdzzz Oct 28, 2024
@mkostoevr mkostoevr force-pushed the m.kostoev/gh-10057-box-schema-user-info branch 2 times, most recently from c72f3af to 471651c Compare June 10, 2025 22:25
@mkostoevr mkostoevr assigned drewdzzz and unassigned mkostoevr Jun 11, 2025
Copy link
Contributor

@drewdzzz drewdzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes!
I have a couple of comments.

@drewdzzz drewdzzz assigned mkostoevr and unassigned drewdzzz Jun 11, 2025
@mkostoevr mkostoevr force-pushed the m.kostoev/gh-10057-box-schema-user-info branch from 471651c to 007cccd Compare June 23, 2025 10:31
@mkostoevr mkostoevr assigned drewdzzz and unassigned mkostoevr Jun 23, 2025
Copy link
Contributor

@drewdzzz drewdzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch, LGTM!

@sergepetrenko sergepetrenko self-requested a review July 16, 2025 13:42
@mkostoevr mkostoevr force-pushed the m.kostoev/gh-10057-box-schema-user-info branch from 007cccd to c4c34a4 Compare July 28, 2025 12:03
Prior to this patch it was not possible for a user to see any role in
the `_vuser` space except the one created by him and the `public` one.

Let's also make it possible to see roles that he is granted with and
all the roles that role is granted transitively. Now calls to the
`box.schema.user.info()` functions won't fail if a user has a non-
'public' role granted.

Closes tarantool#10057

NO_DOC=bugfix
@mkostoevr mkostoevr force-pushed the m.kostoev/gh-10057-box-schema-user-info branch from c4c34a4 to f5cbc0a Compare July 28, 2025 12:05
@mkostoevr mkostoevr removed their assignment Jul 28, 2025
Copy link
Collaborator

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!
LGTM.

@sergepetrenko sergepetrenko added full-ci Enables all tests for a pull request backport/3.2 Automatically create a 3.2 backport PR backport/3.3 Automatically create a 3.3 backport PR backport/3.4 Automatically create a 3.4 backport PR labels Jul 29, 2025
@sergepetrenko sergepetrenko merged commit 0280afc into tarantool:master Jul 29, 2025
62 of 80 checks passed
@TarantoolBot
Copy link
Collaborator

Successfully created backport PR for release/3.2:

@TarantoolBot
Copy link
Collaborator

Successfully created backport PR for release/3.3:

@TarantoolBot
Copy link
Collaborator

Successfully created backport PR for release/3.4:

@TarantoolBot
Copy link
Collaborator

Backport summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/3.2 Automatically create a 3.2 backport PR backport/3.3 Automatically create a 3.3 backport PR backport/3.4 Automatically create a 3.4 backport PR full-ci Enables all tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

box.schema.user.info() - attempt to index a nil value

6 participants