Prepare to drop LSAN suppressions, part 1#10500
Merged
locker merged 4 commits intotarantool:masterfrom Sep 2, 2024
Merged
Conversation
The memleak reported by LSAN is when we use '--name' or '--config' parameters more then once. While we at it let's also fix other possible memory leak reports related to `instance`. Currently we do not free `instance.name` and `instance.config` on all return paths from main. Let's just add instance to the root set so that we don't need to free it's fields to pass LSAN. Part-of tarantool#10211 NO_TEST=covered by existing tests NO_CHANGELOG=minor NO_DOC=bugfix
locker
requested changes
Aug 30, 2024
Space sequence_path memory of space is managed on DDL to space_sequence system space. It all good but on Tarantool shutdown we miss freeing this path which is reported by LSAN. Part-of tarantool#10211 NO_TEST=internal NO_CHANGELOG=internal NO_DOC=internal
Part-of tarantool#10211 NO_CHANGELOG=internal NO_DOC=internal
0197723 to
d81fea2
Compare
locker
approved these changes
Sep 2, 2024
On panic or crash we do not call `lua_close` which causes a lot of PF memory leaks. Part-of tarantool#10211 NO_TEST=internal NO_CHANGELOG=internal NO_DOC=internal
d81fea2 to
94f0b9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10211
Factored out from all-in-one PR #10207