Merged
Conversation
Member
|
Thank you! I will take a look and bundle as a release with the variable font weight support (to avoid multiple XHRs for a single font file) that I've been sitting on for far too long 😬 |
Contributor
Author
|
|
Member
|
This sounds like a job for
The Differ
… On Jun 5, 2020, at 6:27 PM, Brandon Liu ***@***.***> wrote:
FYI, I'm noticing some new, different triangulation artifacts on this new version - will need to confirm if they were introduced by this change
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
Author
|
OK, It looks like the issue I'm seeing is tangram-specific but was not introduced by this PR, so the upgrade should still be good. EDIT: can't reproduce independently, ignore |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was seeing some sliver polygons being created - was resolved by bumping
earcutto the latest. also regenerated the package-lock.json