Conversation
|
|
|
|
||
| bind(unit = 0) { | ||
| if (!this.valid) { | ||
| if (!this.valid || debugSettings.wireframe) { |
There was a problem hiding this comment.
Can you tell me what this check is about? Shouldn't any textures used by the geometry still be valid, even if they are not being used for rendering?
There was a problem hiding this comment.
I'm getting hundreds of these WebGL errors in Chrome with this:
WebGL: INVALID_OPERATION: texImage2D: no texture bound to target
WebGL: INVALID_OPERATION: texParameter: no texture bound to target
[.WebGL-0x7f8b71f16e00]RENDER WARNING: there is no texture bound to the unit 0
I'm not getting any errors with this check removed though, e.g. reverted to original code.
There was a problem hiding this comment.
OK I think I see what you were trying to achieve with this: to get textured points to render as quads, instead of wireframes masked against a sprite?
I will try to think of another way to accomplish this, but we can't disable texture binding this low-level.
There was a problem hiding this comment.
Yep that's the goal – though tbh I've never needed to inspect sprite geometry, I just wanted to try this for completeness
There was a problem hiding this comment.
OK this is my attempt to make these more visible, think it works alright: da98a78
(texture must be bound to support many other calls in rendering pipeline)
…ion instead) clarify wireframe mode only applies to triangles with element data, undefined results otherwise (likely GL errors)
| this.lights = {}; | ||
|
|
||
| if (debugSettings.wireframe) { | ||
| Light.enabled = false; // disable lighting for wireframe mode |
There was a problem hiding this comment.
Turns out this is a more succinct way to disable lighting for wireframe mode, rather than having to create a synthetic light.
| return new VBOMesh(this.gl, vertex_data, vertex_elements, vertex_layout, options); | ||
| return new VBOMesh(this.gl, | ||
| vertex_data, vertex_elements, vertex_layout, | ||
| { ...options, wireframe: debugSettings.wireframe } |
There was a problem hiding this comment.
Moved wireframe option enable here, rather than having it hard-coded inside the VBOMesh, which (ideally) is more generic (though wireframe mode is itself hard-coded to specific data/draw mode format...).
|
Thought about this a bit more, decided to move wireframe building code to its own file, to isolate from "normal" code and remove any special wireframe logic from |
|
Thanks @meetar! This is awesome, wish we'd had it ~4 years ago... |
This is a naive approach to wireframe rendering, which manually edits the VBOMesh.element_data indices to produce three line segments for every triangle.
Textures and lighting are disabled, but vertex colors are still applied.
PR for discussion – would be cool to have this as a debugging option.