Stop error diagnostics when pausing nav (#3830)#1
Merged
tanelikor merged 2 commits intocherry-pick-collision-monitor-limit-to-humblefrom Oct 18, 2023
Merged
Conversation
(cherry picked from commit 57dd8d4)
tanelikor
approved these changes
Oct 13, 2023
Owner
tanelikor
left a comment
There was a problem hiding this comment.
I'm not too familiar with the older lifecycle code but LGTM on the changes. Found one typo that you can fix if you want to, otherwise this seems good to go.
nav2_lifecycle_manager/include/nav2_lifecycle_manager/lifecycle_manager.hpp
Outdated
Show resolved
Hide resolved
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picked the diagnostics changes from rolling.
Tested on simulation!