Add more canonicalization rules for deprecated utilities#19849
Add more canonicalization rules for deprecated utilities#19849RobinMalfait merged 10 commits intomainfrom
Conversation
This also reduces some test duplication and uses a parameterized test instead.
We can't hardcode all the `start-*` utilities, so using a regex instead
We already guard against this, no need to do it again.
Before this, the CSS file would be unique for each deprecated candidate we are testing. That means that we have to create n design systems. By sharing the CSS, we only have to create a single design system.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe canonicalization logic was expanded to handle additional deprecated utilities and dynamic name transformations. The single-step deprecation lookup was replaced with an iterator that yields candidate replacements (including new 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
This PR adds more canonicalization rules for deprecated utilities.
overflow-ellipsistext-ellipsisstart-fullinset-s-full-start-full-inset-s-fullstart-autoinset-s-autostart-pxinset-s-px-start-px-inset-s-pxstart-8inset-s-8-start-8-inset-s-8start-123inset-s-123-start-123-inset-s-123end-fullinset-e-full-end-full-inset-e-fullend-autoinset-e-autoend-pxinset-e-px-end-px-inset-e-pxend-8inset-e-8-end-8-inset-e-8end-123inset-e-123-end-123-inset-e-123In a few cases we already had canonicalization rules, for example
start-8where8is one of the default suggested spacing scale values. But this now adds support for positive and negative values that exceed the default suggested spacing scale as well as some keywords.Test plan