Skip comments in Ruby files when checking for class names#19243
Merged
thecrypticace merged 13 commits intomainfrom Nov 13, 2025
Merged
Skip comments in Ruby files when checking for class names#19243thecrypticace merged 13 commits intomainfrom
thecrypticace merged 13 commits intomainfrom
Conversation
bc1c637 to
fa2be75
Compare
RobinMalfait
reviewed
Nov 3, 2025
Contributor
WalkthroughAdds an Pre-merge checks✅ Passed checks (5 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
crates/oxide/src/extractor/arbitrary_property_machine.rs(3 hunks)crates/oxide/src/extractor/pre_processors/ruby.rs(5 hunks)crates/oxide/src/extractor/pre_processors/test-fixtures/haml/dst-17051.haml(0 hunks)
💤 Files with no reviewable changes (1)
- crates/oxide/src/extractor/pre_processors/test-fixtures/haml/dst-17051.haml
🧰 Additional context used
🧬 Code graph analysis (1)
crates/oxide/src/extractor/pre_processors/ruby.rs (2)
crates/oxide/src/extractor/candidate_machine.rs (1)
next(29-169)crates/oxide/src/extractor/string_machine.rs (1)
next(32-68)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Linux
- GitHub Check: Linux / postcss
- GitHub Check: Linux / vite
- GitHub Check: Linux / upgrade
RobinMalfait
requested changes
Nov 12, 2025
Member
RobinMalfait
left a comment
There was a problem hiding this comment.
Looks good, but not sure about the !important.
Can you also add a changelog entry?
crates/oxide/src/extractor/pre_processors/test-fixtures/haml/dst-17051.haml
Show resolved
Hide resolved
Contributor
Author
|
Yeah I was not gonna change that part. It's unrelated anyway. Will get the change log updated. |
Unless it’s part of `!important` at the end
42f48be to
f381118
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
CHANGELOG.md(1 hunks)crates/oxide/src/extractor/arbitrary_property_machine.rs(3 hunks)crates/oxide/src/extractor/pre_processors/ruby.rs(5 hunks)crates/oxide/src/extractor/pre_processors/test-fixtures/haml/dst-17051.haml(0 hunks)
💤 Files with no reviewable changes (1)
- crates/oxide/src/extractor/pre_processors/test-fixtures/haml/dst-17051.haml
🧰 Additional context used
🧬 Code graph analysis (1)
crates/oxide/src/extractor/pre_processors/ruby.rs (2)
crates/oxide/src/extractor/candidate_machine.rs (1)
next(29-169)crates/oxide/src/extractor/string_machine.rs (1)
next(32-68)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Linux
- GitHub Check: Linux / cli
- GitHub Check: Linux / upgrade
- GitHub Check: Linux / postcss
- GitHub Check: Linux / vite
- GitHub Check: Linux / webpack
RobinMalfait
approved these changes
Nov 13, 2025
This was referenced Dec 11, 2025
This was referenced Dec 11, 2025
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19239