Vite: Don't register the current CSS file as a dependency on itself#17533
Merged
RobinMalfait merged 1 commit intomainfrom Apr 3, 2025
Merged
Vite: Don't register the current CSS file as a dependency on itself#17533RobinMalfait merged 1 commit intomainfrom
RobinMalfait merged 1 commit intomainfrom
Conversation
87119e3 to
53a3eb3
Compare
53a3eb3 to
aaad9b0
Compare
thecrypticace
approved these changes
Apr 3, 2025
RobinMalfait
approved these changes
Apr 3, 2025
Member
RobinMalfait
left a comment
There was a problem hiding this comment.
Verified that the test fails without the fix and passes with the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17512
One of the changes of the Oxide API in 4.1 is that it now emits the input CSS file itself as a dependency. This was fine in most of our testing but it turns out that certain integrations (in this case a Qwik project) don't like this and will silently crash with no CSS file being added anymore.
This PR fixes this by making sure we don't add the input file as a dependency on itself and also adds an integration test to ensure this won't regress again.
Test plan