Fix race condition in Next.js with --turbopack#17514
Merged
philipp-spiess merged 6 commits intomainfrom Apr 3, 2025
Merged
Conversation
47ffb64 to
5372d27
Compare
cf34d7a to
7239bdb
Compare
121fc1f to
10b0c76
Compare
thecrypticace
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where if you use Next.js with
--turbopacka race condition happens because the@tailwindcss/postcssplugin is called twice in rapid succession.The first call sees an update and does a partial update with the new classes. Next some internal
mtimesare updated. The second call therefore doesn't see any changes anymore because themtimesare the same, therefore it's serving its stale data.Fixes: #17508
Processing CSS files with only
@tailwind utilities;While working on a unit test for this, we also noticed that the PostCSS client did nothing at all when the input css contained only the
@tailwind utilities;directive. It turns out that this was a directive that was not being checked for in the fast-bail code so in this PR we also changed it to account for that.Test plan