Ensure strings in Pug and Slim templates are handled correctly#17000
Merged
RobinMalfait merged 5 commits intomainfrom Mar 6, 2025
Merged
Ensure strings in Pug and Slim templates are handled correctly#17000RobinMalfait merged 5 commits intomainfrom
RobinMalfait merged 5 commits intomainfrom
Conversation
The problem here is that our internal `string_machine` is about strings
in Tailwind utilities. This means that spaces are not allowed, but we
can't use that in this context otherwise a string like this:
```
.join(' ')
^ 3. start of new string
^ 2. whitespace is not allowed, stop string
^ 1. start of string
```
This could result in parts of the code to be considered a string when
it's clearly not.
Instead, we will use a custom string consumer implementation that just
keeps reading until the end of the string.
This allows us to run the pre processor and then run the extractor to ensure at least the correct items are extracted that we expect.
thecrypticace
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where strings in the Pug and Slim pre-processor were handled using the
string_machine. However, thestring_machineis not for strings inside of Tailwind CSS classes which means that whitespace is invalid.This means that parts of the code that are inside strings will not be inside strings and parts of the code that are not inside strings will be part of a potential string. This is a bit confusing to wrap your head around, but here is a visual representation of the problem:
Fixes: #16998
Test plan