Don't generate color opacity code in color plugins if not necessary#1680
Merged
adamwathan merged 2 commits intomasterfrom May 1, 2020
Merged
Don't generate color opacity code in color plugins if not necessary#1680adamwathan merged 2 commits intomasterfrom
adamwathan merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new color opacity plugins add a lot of new code to the existing color plugins in order to make the color opacity stuff actually work:
.bg-red-100 { + --bg-opacity: 1; background-color: #fff5f5; + background-color: rgba(255, 245, 245, var(--bg-opacity)); }This sucks if you are disabling the color opacity plugins because now your CSS is bigger, and in a way that PurgeCSS can't help you with.
This PR adds a check to each color plugin to see if the relevant color opacity plugin is disabled, and if so optimizes the output:
.bg-red-100 { - --bg-opacity: 1; background-color: #fff5f5; - background-color: rgba(255, 245, 245, var(--bg-opacity)); }Closes #1670.