Merged
Conversation
545a30b to
491fe9b
Compare
RobinMalfait
approved these changes
Jan 28, 2025
|
in version 4.0.1 the bug is still present (almost for angular shorthand syntax) |
Contributor
Author
|
@paolominel What's the exact file you've used that doesn't work? |
|
I use tailwind classes in angular host component.
active variable was a signal inside the relative angular component. this class was not fired and not compiled during tailwind class scanning. |
|
still present in version 4.0.3. tried this morning after library upgrade |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15632
Fixes #15740
This PR fixes a number of Oxide scanner bugs reported over various channels, specifically:
When using the Svelte class shorthand split over various lines, we weren't extracting class names properly:
We now extract classes when using the class shortcut in Angular:
We now validate parentheses within arbitrary candidates so that we don't consume invalid arbitrary candidates anymore which allows us to parse the following case properly:
Test plan
Added unit tests