fix(oxide): preserve symlink paths for source ignores

yudin-s · yudin-s · commit fe9f52e870ad · 2026-05-20T18:13:49.000+03:00
diff --git a/crates/oxide/src/scanner/sources.rs b/crates/oxide/src/scanner/sources.rs
@@ -1,7 +1,7 @@
 use crate::glob::split_pattern;
 use crate::GlobEntry;
 use bexpand::Expression;
-use std::path::PathBuf;
+use std::path::{Component, Path, PathBuf};
 use tracing::{event, Level};
 
 use super::auto_source_detection::IGNORED_CONTENT_DIRS;
@@ -116,12 +116,12 @@ impl PublicSourceEntry {
                 PathBuf::from(&self.base).join(&self.pattern)
             };
 
-            match dunce::canonicalize(combined_path) {
-                Ok(resolved_path) if resolved_path.is_dir() => {
+            match resolve_path(&combined_path, self.negated) {
+                Ok(resolved_path) if combined_path.is_dir() => {
                     self.base = resolved_path.to_string_lossy().to_string();
                     self.pattern = "**/*".to_owned();
                 }
-                Ok(resolved_path) if resolved_path.is_file() => {
+                Ok(resolved_path) if combined_path.is_file() => {
                     self.base = resolved_path
                         .parent()
                         .unwrap()
@@ -144,7 +144,7 @@ impl PublicSourceEntry {
             Some(static_part) => {
                 // TODO: If the base does not exist on disk, try removing the last slash and try
                 // again.
-                match dunce::canonicalize(base.join(static_part)) {
+                match resolve_path(&base.join(static_part), self.negated) {
                     Ok(base) => base,
                     Err(err) => {
                         event!(tracing::Level::ERROR, "Failed to resolve glob: {:?}", err);
@@ -171,6 +171,31 @@ impl PublicSourceEntry {
     }
 }
 
+fn resolve_path(path: &Path, preserve_symlinks: bool) -> std::io::Result<PathBuf> {
+    if preserve_symlinks {
+        path.metadata()?;
+        return Ok(normalize_path_lexically(path));
+    }
+
+    dunce::canonicalize(path)
+}
+
+fn normalize_path_lexically(path: &Path) -> PathBuf {
+    let mut normalized = PathBuf::new();
+
+    for component in path.components() {
+        match component {
+            Component::CurDir => {}
+            Component::ParentDir => {
+                normalized.pop();
+            }
+            component => normalized.push(component.as_os_str()),
+        }
+    }
+
+    normalized
+}
+
 /// For each public source entry:
 ///
 /// 1. Perform brace expansion
diff --git a/crates/oxide/tests/scanner.rs b/crates/oxide/tests/scanner.rs
@@ -1761,6 +1761,25 @@ mod scanner {
         assert_eq!(candidates, vec!["content-['abcd/xyz.html']"]);
     }
 
+    #[test]
+    fn test_source_not_can_ignore_symlinked_directory() {
+        let dir = tempdir().unwrap().into_path();
+        create_files_in(
+            &dir,
+            &[("directory_a/a.html", "content-['directory_a/a.html']")],
+        );
+        let _ = symlink(dir.join("directory_a"), dir.join("symlink"));
+
+        let mut scanner = Scanner::new(vec![
+            public_source_entry_from_pattern(dir.clone(), "@source './'"),
+            public_source_entry_from_pattern(dir.clone(), "@source not './symlink'"),
+            public_source_entry_from_pattern(dir.clone(), "@source not './directory_a'"),
+        ]);
+        let candidates = scanner.scan();
+
+        assert!(candidates.is_empty());
+    }
+
     #[test]
     fn test_extract_used_css_variables_from_css() {
         let dir = tempdir().unwrap().into_path();
