cleanup

RobinMalfait · RobinMalfait · commit 756c19caecb3 · 2026-06-17T22:09:34.000+02:00
- Bail early when we know nothing changed
- Remove unnecessary `.clone()` calls
- Use `metadata` on `path` directly
diff --git a/crates/oxide/src/scanner/mod.rs b/crates/oxide/src/scanner/mod.rs
@@ -382,20 +382,19 @@ impl Scanner {
 
         for (path, is_dir, extension) in all_entries {
             if is_dir {
-                self.dirs.insert(path.clone());
+                self.dirs.insert(path);
             } else {
                 // Deduplicate: parallel walk can visit the same file from multiple threads
                 if !self.files.insert(path.clone()) {
                     continue;
                 }
+                self.extensions.insert(extension.clone());
 
                 // On re-scans, check mtime to skip unchanged files.
                 // On the first scan we skip this entirely to avoid extra
                 // metadata syscalls.
                 let changed = if self.has_scanned_once {
-                    let current_mtime = std::fs::metadata(&path)
-                        .ok()
-                        .and_then(|m| m.modified().ok());
+                    let current_mtime = path.metadata().ok().and_then(|m| m.modified().ok());
 
                     match current_mtime {
                         Some(mtime) => {
@@ -408,22 +407,16 @@ impl Scanner {
                     true
                 };
 
+                if !changed {
+                    continue;
+                }
+
                 match extension.as_str() {
                     // Special handing for CSS files, we don't want to extract candidates from
                     // these files, but we do want to extract used CSS variables.
-                    "css" => {
-                        if changed {
-                            css_files.push(path.clone());
-                        }
-                    }
-                    _ => {
-                        if changed {
-                            content_paths.push((path.clone(), extension.clone()));
-                        }
-                    }
+                    "css" => css_files.push(path),
+                    _ => content_paths.push((path, extension)),
                 }
-
-                self.extensions.insert(extension);
             }
         }
 
