Match against correct name of dynamic attributes when using regexes#410
Merged
thecrypticace merged 2 commits intomainfrom Oct 16, 2025
Merged
Match against correct name of dynamic attributes when using regexes#410thecrypticace merged 2 commits intomainfrom
thecrypticace merged 2 commits intomainfrom
Conversation
Some of these would’ve caught a bug if written correctly 🤦♂️
Dynamic attribute names have definite rules in Vue and Angular. Testing those rules directly and matching the actual “name” portion against the regex is a better option.
c712a7f to
f0b60cc
Compare
| if (parser === 'vue') { | ||
| if (name.startsWith(':')) return name.slice(1) | ||
| if (name.startsWith('v-bind:')) return name.slice(7) | ||
| if (name.startsWith('v-')) return name |
Member
There was a problem hiding this comment.
Do we want to slice until the = or :?
Contributor
Author
There was a problem hiding this comment.
Nope, the parser has already split the name and value and this only matches against the name.
As for the : I think that is only useful with v-bind. Can always change this in the future if we need to.
RobinMalfait
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #409
A regex like
/.*-class/was matching:custom-classin Vue files but considered it a static attribute. This is incorrect.The current implementation was based on a previous version where it built up attribute lists for fast Set-based matching. But really the rules for the parser should just be encoded directly as Vue and Angular have fairly specific rules about which attributes are dynamic vs. static.
This tweaks things to encode those rules directly and fixes the above as a result.