cmd/containerboot: set TS_AUTH_ONCE default to true. #9573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63b38ef to
e086939
Compare
Contributor
Author
|
Updated comment on line 38. |
maisem
approved these changes
Sep 29, 2023
cmd/containerboot/main.go
Outdated
| // container starts. | ||
| // logged in. If false, forcibly log in every time the container starts. | ||
| // The default until 1.50.0 was false, but that was misleading: until | ||
| // 1.50, containerbook used `tailscale up` which would ignore an authkey |
Contributor
Author
There was a problem hiding this comment.
I've been doing so much in German recently I'm surprised this didn't come out as Containerbuch.
1.50.0 switched containerboot from using `tailscale up` to `tailscale login`. A side-effect is that a re-usable authkey is now re-applied on every boot by `tailscale login`, where `tailscale up` would ignore an authkey if already authenticated. Though this looks like it is changing the default, in reality it is setting the default to match what 1.48 and all prior releases actually implemented. Fixes #9539 Fixes https://github.com/tailscale/corp/issues/14953 Signed-off-by: Denton Gentry <dgentry@tailscale.com>
e086939 to
e8e08ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.50.0 switched containerboot from using
tailscale uptotailscale login. A side-effect is that a re-usable authkey is now re-applied on every boot bytailscale login, wheretailscale upwould ignore an authkey if already authenticated.Though this looks like it is changing the default, in reality it is setting the default to match what 1.48 and all prior releases actually implemented.
Fixes #9539
Fixes https://github.com/tailscale/corp/issues/14953