wgengine/netstack: add a missing refcount decrement after packet injection #3764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maisem
approved these changes
Jan 19, 2022
| Data: vv, | ||
| }) | ||
| ns.linkEP.InjectInbound(pn, packetBuf) | ||
| packetBuf.DecRef() |
Contributor
There was a problem hiding this comment.
optional: would be nice to add tests for this
Member
Author
There was a problem hiding this comment.
yeah, still thinking about that. I think the integration tests somehow, but that seems slow & unreliable.
I'd like something tighter.
Change-Id: Idbb3fd6d749d3e4effdf96de77a1106584822fef Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2fd3f97 to
25c59f6
Compare
25c59f6 to
388c7dd
Compare
maisem
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3762
Updates #3745 (probably fixes?)