net/portmapper: ignore IGD SSDP responses from !defaultgw #3202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we multicast the SSDP query, we can get IGD offers from devices other than the current device's default gateway. We don't want to accidentally bind ourselves to those. Updates #3197 Signed-off-by: David Anderson <danderson@tailscale.com>
bradfitz
approved these changes
Oct 27, 2021
|
Note to future users: this can cause UPnP and NAT-PMP to not be detected behind OPNSense (and presumably pfSense) in a failover pair, since the routers respond on their interface IP rather than the virtual IP probably used as the gateway. I was able to work around this for tailscale by port forwarding 5351/udp from the virtual gateway IP to the primary router's LAN interface IP. Not perfect (will not work during failover), but gets things working during normal operations. |
Contributor
|
Could you file a bug about this, with a description? The intent of this PR was not to preclude use of portmapping in valid cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we multicast the SSDP query, we can get IGD offers from
devices other than the current device's default gateway. We don't want
to accidentally bind ourselves to those.
Updates #3197
Signed-off-by: David Anderson danderson@tailscale.com