feat: support operation validation via check command#706
Merged
tusharmath merged 58 commits intotailcallhq:mainfrom Jan 15, 2024
Merged
feat: support operation validation via check command#706tusharmath merged 58 commits intotailcallhq:mainfrom
check command#706tusharmath merged 58 commits intotailcallhq:mainfrom
Conversation
b4s36t4
suggested changes
Nov 30, 2023
wesleymatosdev
suggested changes
Dec 1, 2023
Contributor
wesleymatosdev
left a comment
There was a problem hiding this comment.
We need to find a way to write automated tests to this feature
fb47ab6 to
9b07659
Compare
tusharmath
reviewed
Dec 2, 2023
tusharmath
reviewed
Dec 2, 2023
tusharmath
reviewed
Dec 2, 2023
wesleymatosdev
suggested changes
Dec 2, 2023
|
Action required: PR inactive for 2 days. |
e9bb7ee to
062f834
Compare
tobihans
commented
Dec 4, 2023
ebfa0cb to
2f86f4b
Compare
meskill
reviewed
Dec 7, 2023
2f86f4b to
61d901c
Compare
|
Action required: PR inactive for 2 days. |
Contributor
Author
|
Thanks for the branch update @tusharmath. I'm currently really sick. I hope to feel better soon and complete this. It remains to write automated tests like in |
|
Action required: PR inactive for 2 days. |
tusharmath
reviewed
Jan 13, 2024
tusharmath
reviewed
Jan 13, 2024
9a574a5 to
441412b
Compare
tusharmath
reviewed
Jan 14, 2024
tusharmath
reviewed
Jan 14, 2024
tusharmath
reviewed
Jan 14, 2024
tusharmath
reviewed
Jan 14, 2024
tusharmath
reviewed
Jan 14, 2024
operations to check commandcheck command
check commandcheck command
tusharmath
approved these changes
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR add ability to check that the schema is able to execute some operations. It follows the second approach outlined in the issue.
It's worth noting that the validation depends on the
queryValidationparameter of the@serverdirective, as the query is executed against the schema (with resolvers that don't actually do anything).Given a the sample schema
jsonplaceholder.graphqland two operationsposts.graphqlandempty.graphql, we get the output below.jsonplaceholder.graphqlposts.graphqlempty.graphql: well, it's emptyIssue Reference(s):
Fixes #416
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
Fun fact:
I mistakenly deleted the branch, which closed the first PR I opened.
/claim #416