fix custom root types for graphql#676
Merged
tusharmath merged 7 commits intotailcallhq:mainfrom Nov 21, 2023
Merged
Conversation
2 tasks
Contributor
Author
|
@tusharmath Please review. |
…x/allow-custom-root-types
c73dfe1 to
96671ae
Compare
Contributor
|
can you add a test @b4s36t4 |
…call into fix/allow-custom-root-types
Contributor
Author
|
@tusharmath I have added a test case can you check? |
Contributor
|
Fantastic @b4s36t4 thanks 🙏 |
tusharmath
approved these changes
Nov 21, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #667
/claim #667
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist: