Skip to content

fix: add validation that root resolvers are existing in schema for query and mutation#362

Merged
tusharmath merged 3 commits intotailcallhq:mainfrom
meskill:fix/root-resolver-validation
Oct 1, 2023
Merged

fix: add validation that root resolvers are existing in schema for query and mutation#362
tusharmath merged 3 commits intotailcallhq:mainfrom
meskill:fix/root-resolver-validation

Conversation

@meskill
Copy link
Copy Markdown
Contributor

@meskill meskill commented Sep 28, 2023

Summary:
Add validation that root resolvers are present both for query and mutation

/claim #207

Issue Reference(s):
Fixes #207

Build & Testing:

  • The build is passing.
  • I have run ./lint.sh to address and fix linting issues.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly (if applicable).
  • I have performed a self-review of my own code.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3b37d0f) 82.35% compared to head (e92b454) 82.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   82.35%   82.50%   +0.14%     
==========================================
  Files          46       46              
  Lines        4104     4139      +35     
==========================================
+ Hits         3380     3415      +35     
  Misses        724      724              
Files Coverage Δ
src/blueprint/from_config.rs 96.49% <100.00%> (+0.29%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meskill meskill marked this pull request as ready for review September 29, 2023 11:04
@meskill meskill force-pushed the fix/root-resolver-validation branch from 2f37465 to e92b454 Compare October 1, 2023 09:49
@tusharmath tusharmath merged commit 8e6821d into tailcallhq:main Oct 1, 2023
@meskill meskill deleted the fix/root-resolver-validation branch October 1, 2023 12:08
@tusharmath tusharmath added bug and removed bug labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation for missing resolvers at Root level

2 participants