Skip to content

fix: add validation for undeclared types and unions#338

Merged
tusharmath merged 6 commits intotailcallhq:mainfrom
meskill:fix/undeclared-type-validation
Sep 28, 2023
Merged

fix: add validation for undeclared types and unions#338
tusharmath merged 6 commits intotailcallhq:mainfrom
meskill:fix/undeclared-type-validation

Conversation

@meskill
Copy link
Copy Markdown
Contributor

@meskill meskill commented Sep 26, 2023 •
edited
Loading

/claim #334

@github-actions github-actions bot added the bug label Sep 26, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3f5f690) 80.37% compared to head (c309449) 80.71%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   80.37%   80.71%   +0.34%     
==========================================
  Files          46       46              
  Lines        3877     3920      +43     
==========================================
+ Hits         3116     3164      +48     
+ Misses        761      756       -5
Files Coverage Δ
src/config/from_document.rs 98.17% <100.00%> (ø)
src/config/into_document.rs 88.29% <100.00%> (ø)
src/config/n_plus_one.rs 99.63% <100.00%> (ø)
src/valid/valid.rs 96.07% <100.00%> (+9.65%) ⬆️
src/blueprint/from_config.rs 96.41% <98.00%> (+0.39%) ⬆️
src/config/config.rs 81.51% <75.00%> (-1.68%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algora-pbc algora-pbc bot mentioned this pull request Sep 26, 2023
Closed
4 tasks
tusharmath
tusharmath reviewed Sep 27, 2023
View reviewed changes
tusharmath
tusharmath reviewed Sep 27, 2023
View reviewed changes
tusharmath
tusharmath reviewed Sep 27, 2023
View reviewed changes
tusharmath
tusharmath reviewed Sep 27, 2023
View reviewed changes
@tusharmath tusharmath changed the title fix: add validation for undeclared types and unions Fix: Add validation for undeclared types and unions Sep 27, 2023
@tusharmath tusharmath force-pushed the fix/undeclared-type-validation branch from 2f89858 to 8a1d6ae Compare September 27, 2023 16:06
@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented Sep 27, 2023

@meskill this is a fmt error can you have a look.

@meskill meskill force-pushed the fix/undeclared-type-validation branch from 8a1d6ae to c3ab3f3 Compare September 27, 2023 16:10
@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented Sep 27, 2023

/tip $100

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Sep 27, 2023

👉 @tusharmath: Click here to proceed

@meskill
Copy link
Copy Markdown
Contributor Author

meskill commented Sep 27, 2023

@meskill this is a fmt error can you have a look.

Could you rerun the workflow? I've fixed formatting

@tusharmath tusharmath merged commit 49e39e1 into tailcallhq:main Sep 28, 2023
@meskill meskill deleted the fix/undeclared-type-validation branch September 28, 2023 05:51
@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Sep 28, 2023

🎉🎈 @meskill has been awarded $100! 🎈🎊

@tusharmath tusharmath changed the title Fix: Add validation for undeclared types and unions fix: add validation for undeclared types and unions Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tusharmath tusharmath tusharmath approved these changes

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@meskill @tusharmath