Skip to content

fix(2775): send metrics to posthog#2776

Closed
beelchester wants to merge 20 commits intotailcallhq:mainfrom
beelchester:chore/posthog
Closed

fix(2775): send metrics to posthog#2776
beelchester wants to merge 20 commits intotailcallhq:mainfrom
beelchester:chore/posthog

Conversation

@beelchester
Copy link
Copy Markdown
Contributor

@beelchester beelchester commented Sep 1, 2024 •
edited
Loading

fixes: #2775
/claim #2775

Screenshot 2024-09-01 at 5 44 44 PM

Steps to test:

  1. Add posthog project api key to env POSTHOG_API_SECRET.
  2. For local testing I had to hardcode is_tracking to true.
  3. Run cargo test on tailcall-tracker or just use build the project and run any argument.
  4. Check the activity section in posthog project events should appear.

@beelchester
chore: send metrics to posthog
8b54494 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester beelchester marked this pull request as draft September 1, 2024 09:06
@algora-pbc algora-pbc bot mentioned this pull request Sep 1, 2024
Closed
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Sep 1, 2024
@beelchester
fix: event name and client id
031271e 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
refact: ga tracker url
23b1a91 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.90503% with 138 lines in your changes missing coverage. Please review.

Project coverage is 87.12%. Comparing base (7464f76) to head (430848b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tailcall-tracker/src/tracker.rs 24.41% 65 Missing ⚠️
tailcall-tracker/src/collect/posthog.rs 9.37% 29 Missing ⚠️
tailcall-tracker/src/collect/ga.rs 20.00% 28 Missing ⚠️
src/cli/command.rs 0.00% 7 Missing ⚠️
tailcall-tracker/src/event.rs 0.00% 5 Missing ⚠️
src/cli/tc/run.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2776      +/-   ##
==========================================
- Coverage   87.30%   87.12%   -0.19%     
==========================================
  Files         254      256       +2     
  Lines       25311    25418     +107     
==========================================
+ Hits        22099    22146      +47     
- Misses       3212     3272      +60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beelchester
remove unwraps and rename ga event
0a1b97d 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester beelchester marked this pull request as ready for review September 1, 2024 11:14
@beelchester
add metrics: start_time, version, uptime
3c95ec8 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix: build
006b178 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
refact: uptime
43b715a 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
tusharmath
tusharmath reviewed Sep 1, 2024
View reviewed changes
Comment thread tailcall-tracker/src/ga_event.rs Outdated
tusharmath
tusharmath reviewed Sep 1, 2024
View reviewed changes
Comment thread tailcall-tracker/src/tracker.rs
tusharmath
tusharmath reviewed Sep 1, 2024
View reviewed changes
Comment thread tailcall-tracker/src/helpers.rs Outdated
tusharmath
tusharmath reviewed Sep 1, 2024
View reviewed changes
Comment thread tailcall-tracker/src/collect/mod.rs
@tusharmath tusharmath marked this pull request as draft September 1, 2024 12:54
@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented Sep 1, 2024

  • Added comments
  • CI is failing which needs fixing
  • Add steps to test the feature

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

@tusharmath tusharmath added type: feature Brand new functionality, features, pages, workflows, endpoints, etc. and removed type: chore Routine tasks like conversions, reorganization, and maintenance work. labels Sep 1, 2024
@tusharmath tusharmath changed the title chore(2775): send metrics to posthog feat(2775): send metrics to posthog Sep 1, 2024
beelchester and others added 5 commits September 1, 2024 21:00
@beelchester
use collectors struct
e471c44 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
Merge branch 'main' into chore/posthog
cc9ee90
@beelchester
use credentials from env
96f0ae6 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix: build
cae1636 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix: lint
f3c8fd6 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester beelchester marked this pull request as ready for review September 2, 2024 02:00
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 7, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 7, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 8, 2024
@tusharmath tusharmath changed the title feat(2775): send metrics to posthog fix(2775): send metrics to posthog Sep 10, 2024
@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Sep 15, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 20, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 20, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 21, 2024
@tusharmath tusharmath removed the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Sep 21, 2024
@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented Sep 21, 2024

closing in favour of #2879

@tusharmath tusharmath closed this Sep 21, 2024
@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented Sep 21, 2024

/tip $25

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Sep 21, 2024

🎉🎈 @beelchester has been awarded $25! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tusharmath tusharmath tusharmath left review comments

Assignees

No one assigned

Labels

🙋 Bounty claim 💰 Rewarded type: fix Iterations on existing features or infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Push data to PostHog

2 participants

@beelchester @tusharmath