fix(cli): set provider and model atomically#2885
Merged
tusharmath merged 10 commits intomainfrom Apr 8, 2026
Merged
Conversation
tusharmath
commented
Apr 8, 2026
crates/forge_main/src/ui.rs
Outdated
| self.on_model_selection(None).await?; | ||
| } | ||
| SlashCommand::Provider => { | ||
| self.on_provider_selection().await?; |
Collaborator
Author
There was a problem hiding this comment.
Provider selection can be dropped and aliased to login.
| "/help" => Ok(SlashCommand::Help), | ||
| "/model" => Ok(SlashCommand::Model), | ||
| "/provider" => Ok(SlashCommand::Provider), | ||
| "/provider" | "/login" => Ok(SlashCommand::Login), |
Contributor
There was a problem hiding this comment.
The /provider command is now mapped to SlashCommand::Login, but this is incorrect. The Provider slash command variant was removed (lines 398-401), but /provider should either:
- Be removed entirely as an available command, or
- Map to
SlashCommand::Model(since provider selection is now part of model selection)
Mapping it to login will confuse users who type /provider expecting to switch providers but instead get the login flow.
// Remove this line:
"/provider" | "/login" => Ok(SlashCommand::Login),
// Should be:
"/login" => Ok(SlashCommand::Login),
Suggested change
| "/provider" | "/login" => Ok(SlashCommand::Login), | |
| "/login" => Ok(SlashCommand::Login), |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
amitksingh1490
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.